Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default implementations from headers. #158

Open
PiotrSikora opened this issue Apr 26, 2021 · 0 comments
Open

Remove default implementations from headers. #158

PiotrSikora opened this issue Apr 26, 2021 · 0 comments

Comments

@PiotrSikora
Copy link
Member

From #156 (comment):

We should remove default implementations (e.g. getCurrentTimeNanoseconds) from headers, to avoid accidentally leaking them into production code... and then we can have a dummy Context implementation used for tests in this repo.

cc @mathetake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant