Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re support the StopIteration status #417

Open
wbpcode opened this issue Sep 19, 2024 · 2 comments
Open

re support the StopIteration status #417

wbpcode opened this issue Sep 19, 2024 · 2 comments

Comments

@wbpcode
Copy link

wbpcode commented Sep 19, 2024

We converted all StopIteration to StopAll at #95.

It make the wasm filter couldn't work in some typically scenarios, for example, custom auth may require to parse body to complete the authentication, but return Continue when calling onRequestHeaders will proxy headers to uptream before we complete the authentication, return StopAll will prohibit the wasm to access body.

@mpwarres
Copy link
Contributor

#143 discusses the same (or similar) issue, suggest deduping and reviving the discussion there, unless there is a different aspect to this issue. @wbpcode WDYT?

@wbpcode
Copy link
Author

wbpcode commented Sep 19, 2024

yea, it's the same issue. This is a very important feature for a bunch of filters.

Without it, we even cannot set the content length correctly after mutate the body. It's weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants