Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasi: support monotonic clock on clock_time_get. #156

Merged
merged 4 commits into from
May 6, 2021

Conversation

mathetake
Copy link
Contributor

@mathetake mathetake commented Apr 26, 2021

Signed-off-by: Takeshi Yoneda takeshi@tetrate.io

resolves proxy-wasm/proxy-wasm-rust-sdk#103

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
src/exports.cc Outdated Show resolved Hide resolved
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
test/exports_test.cc Outdated Show resolved Hide resolved
include/proxy-wasm/context.h Show resolved Hide resolved
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Please merge only after the relevant Envoy PR is approved and passes tests.

@mathetake mathetake merged commit 31c75e0 into proxy-wasm:master May 6, 2021
@mathetake mathetake deleted the monotonic-clock branch May 6, 2021 07:40
lizan pushed a commit to envoyproxy/envoy that referenced this pull request May 7, 2021
Supports clock_time_get in WASI with monotonic clock_id. Ref: proxy-wasm/proxy-wasm-cpp-host#156 and proxy-wasm/proxy-wasm-rust-sdk#103

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
@mathetake mathetake restored the monotonic-clock branch June 1, 2021 05:20
@mathetake mathetake deleted the monotonic-clock branch June 1, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with monotonic clocks
2 participants