Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login state inconsistencies #152

Closed
Kaptard opened this issue Jul 28, 2023 · 3 comments · Fixed by #153
Closed

Fix login state inconsistencies #152

Kaptard opened this issue Jul 28, 2023 · 3 comments · Fixed by #153

Comments

@Kaptard
Copy link
Member

Kaptard commented Jul 28, 2023

Current behavior

Player's login states still aren't consistent with the in-game realities. Server restarts and downtimes are already accounted for, so the next most plausible explanation are missing census events. It may be worth cross-referencing affected players with the alts API, which stores its own online state.

Expected behavior

The online state must be accurate, so we can release the alt wide friends list. If we cannot fix the problem at it's core, we should integrate inactivity timers which will manually reset a player's online state.

Definition of Done

@Kaptard Kaptard changed the title Investigate login state inconsistencies Fix login state inconsistencies Jul 28, 2023
@Kaptard Kaptard self-assigned this Jul 30, 2023
@Kaptard
Copy link
Member Author

Kaptard commented Jul 30, 2023

It appears G15 errors will trigger a login event, but no subsequent logout until that player relaunches the game.

@Kaptard
Copy link
Member Author

Kaptard commented Jul 30, 2023

Killing the Planetside process causes the same issue.

@Kaptard
Copy link
Member Author

Kaptard commented Jul 30, 2023

Should be fixable by setting a lastActivityAt flag on player entities with a scheduled task for resetting online states after 10 minutes. The lastActivityAt flag would be set on any related census event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant