Add Debian package meta-info and GitHub package builder action #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a starting point, I ran the following command and then minimized the configuration for stand-alone builds: dh-make-golang github.com/psanford/tpm-fido I created the debian/changelog file by running the following: debchange --create I used the following command to update the changelog version: git log --date=format:%Y%m%d --pretty="0.0~git%cd.%h-1"
I just ran "debchange -i" and added a note. In the future, you can just keep running "debchange -i" to increment the revision on this same entry. When you would line to change it to an actual release, you just run "debchange -r".
|
Hi @psanford! I'm more than happy to change the references to my name/email to your name/email, but I just wanted to check if you were okay with putting your name/email in the text files, before doing so. Let me know what you think! |
linux4life798
commented
May 6, 2024
|
|
||
| * Initial release. | ||
|
|
||
| -- Craig Hesling <craig@hesling.com> Sun, 05 May 2024 20:23:37 -0700 |
There was a problem hiding this comment.
Here is a name/email that I can happily change to your name/email.
linux4life798
commented
May 6, 2024
| Section: golang | ||
| Priority: optional | ||
| Maintainer: Debian Go Packaging Team <team+pkg-go@tracker.debian.org> | ||
| Uploaders: Craig Hesling <craig@hesling.com> |
There was a problem hiding this comment.
Here is another name/email that I can happily change to your name/email.
linux4life798
referenced
this pull request
in bast1aan/scripts
May 6, 2024
Safe installer and small GUI extension to the great tpm-fido tool https://github.com/psanford/tpm-fido
|
Thanks for the pr! My philosophy is that packaging specific changes belong in the respective distribution repositories. I would encourage you to open this pr directly with Debian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a complete Debian package meta description and a GitHub action to build it.
The built package automatically sets up the groups and services needed to automatically run tpm-fido.
Specifically, the Debian meta information does the following:
Before adding the uhid-permission boot job, I did attempt to get udev to change the permission of /dev/uhid.
However, I couldn't figure out how to get udev to trigger, since it doesn't seem to receive any events about /dev/uhid, until
after a service requests a new virtual hid. See the debian/tpm-fido.udev.disabled file for more detail.
The GitHub action is pretty basic. It checks out the source, opens a Debian docker container, installs the build dependencies (package), runs the dpkg-buildpackage command, and then uploads the output package+build-info as an action artifact.
So, you can just download these artifacts and install away.
I tried to add as many comments and references as possible to help with understanding and maintenance.