Assorted fixes for code rot #6
Conversation
Fix the tox.ini commands to use the correct test suite path, and run it via unittest since executing the file does not do anything.
Relax the dependency bounds in `setup.py` to permit the newest versions that are compatible with the current httpbin code, that is permit the test suite to pass.
Remove the check for `Content-Length` header that is not provided by default anymore with werkzeug 0.15.x. See: pallets/werkzeug#2347 Taken from postmanlabs#684
Since the newer dependency versions and the code itself are now compatible with newer Python versions, we can test the package up to 3.12. Add pypy3 to the test matrix while at it.
Update the code for werkzeug 2.1.x where `BaseResponse` class was replaced by `Response`. See: pallets/werkzeug#2276 Taken from postmanlabs#684
Fix passing bytes instead of str as the URL to .get() function. This fixes one of the test failures with werkzeug 2.3.x.
Remove the dependency on raven, as the code using it has been removed in e543380.
The brotlipy package has been renamed to brotlicffi. Update the imports and dependencies accordingly. The major advanage of the new package is that it no longer collides with the Python bindings provided by brotli itself.
Fix digest tests to check for `stale=True` case-insensitively, in order to maintain compatibility with werkzeug < 2.3 (that used `stale=TRUE`) and >= 2.3 (that uses `stale=True`).
|
Ok, that accounts for all the patches we've had in Gentoo, and gives me a clean test pass with newest versions of |
|
Thanks for your work on this @mgorny. Could you take a look at the test failure on windows? Not sure what that's all about. |
|
Thanks. I'll try to take a look in a few minutes, just when I'm done with my immediate TODO. |
It seems that the problem is that |
Here's a combined effort to update the package after all the code rot. So far I've focused on fixing running the test suite via
toxand now I'm working on fixing compatibility with newer versions of packages. It's partially my work and partially stuff taken from existing PRs.Technically it's a work-in-progress but I'm doing things atomically, so it's fine to merge it at any point, and I'll just rebase.