Set verify=True by default as documented #6624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is (as far as the library is concerned) semantically incorrect. None here is meant as a (poor) substitute for "not specified explicitly by user". Changing this means that the user ostensibly always wants verification on. The tests that are failing show how broken this change is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation clearly states that the default for
verifyisTrue. Via merge_environment_settings() and merge_settings() the behaviour ofNoneis made the same asTruebecauseself.verifyis initialized asTruebut this is rather non-intuitive. Let's make the actual default of request() functionTrueas per the documentation.