Allow optional char detection dependencies in post-packaging #6702
+60
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
force-pushed
the
no_char_detection
branch
from
17e7e21
to
555b870
Compare
sigmavirus24
approved these changes
May 15, 2024
Merged
nijel
reviewed
May 22, 2024
| def _resolve_char_detection(): | ||
| """Find supported character detection libraries.""" | ||
| chardet = None | ||
| for lib in ("chardet", "charset_normalizer"): |
There was a problem hiding this comment.
While this keeps the logic of the earlier code, I think that the library which is required on should be tried first. #6714 addresses this.
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposal to relax our requirement to have a character detection library present with all installations of Requests. While we cannot remove our reliance on
charset_normalizerorchardet, there are use cases where Requests is repackaged in applications or other tools that do not need our character detection behavior. These changes will enable them to remove those dependencies from their installation.The current use case for this shift is to allow
pipto remove these dependencies entirely. That should slim the package ~2MB in 24.1.0 and avoid the overhead of importing the unneeded dependency.