Create tests for multiple files #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…labels are configured
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
biodatamodule and its associated tests. The main updates involve refactoring label handling, fixing label assignment logic, and adding new test cases to ensure data loading works correctly under various conditions.Refactoring and Logic Fixes:
src/biosets/packaged_modules/biodata/biodata.py: Refactored label handling in_set_labelsby removing redundant checks and simplifying the label-to-integer mapping.src/biosets/packaged_modules/biodata/biodata.py: Corrected the order of parameters in thefnfunction call to ensure labels are correctly assigned.src/biosets/packaged_modules/biodata/biodata.py: Added a check for the presence oflabelsin_generate_tablesto handle cases where both positive and negative labels are not provided.Test Enhancements:
tests/packaged_modules/test_biodata.py: Reorganized imports with ruff. [1] [2]tests/packaged_modules/test_biodata.py: Re-enabled and added multiple test cases to cover scenarios with multiple files and various label configurations, including positive and negative labels.