Fix exporter; bring up-to-date; add flake8 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream-website seems to have changed the format in which they provide this value. After changing it to a float the exporter works for me again like expected.
TobiasKadelka
force-pushed
the
repair
branch
2 times, most recently
from
6842562 to
e24684b
Compare
TobiasKadelka
changed the title
The usage did error for me because of the format --web.listen-address seems to expect -- I assume that comment was out of date. The relative import did only work when I then run the project from the directory in which main.py is, not from the root of the repository.
aqw
approved these changes
Mar 20, 2024
| group = parser.add_argument_group() | ||
| group.add_argument( | ||
| '-w', '--web.listen-address', | ||
| type=str, | ||
| dest='listenaddress', | ||
| help='Address and port to expose metrics and web interface. Default: ":9184"\n' | ||
| 'To listen on all interfaces, omit the IP. ":<port>"\n' | ||
| 'To listen on all interfaces, omit the IP: ":<port>"\n' |
There was a problem hiding this comment.
IIRC, this behavior recently changed...
There was a problem hiding this comment.
Dang it, I forgot about that.
I would follow the eaton-ups-exporter and change it to 0.0.0.0
The existing CI workflow file did never run. 3.6 from before made problems during CI.
|
Thanks, I added your suggestions and changed the default address to |
aqw
requested changes
Mar 20, 2024
| @@ -27,7 +27,7 @@ def main(): | |||
| else: # listen on all interfaces | |||
There was a problem hiding this comment.
This is the behavior that changed upstream.
IIRC, the old behavior was to listen on all interfaces if it's not specified. Now it's 127.0.0.1.
I'm not certain though, so you should check into that.
There was a problem hiding this comment.
We talked and the changes around this will be addressed in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exporter did error, possibly because the website queried changed a value from int to float.
Another bug I noticed was that a script for CI was added before, but never triggered.
Changes:
wind_powerto float