Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Royalty Registry Contract #13

Merged
merged 18 commits into from
Aug 24, 2023
Merged

Royalty Registry Contract #13

merged 18 commits into from
Aug 24, 2023

Conversation

tasiov
Copy link
Contributor

@tasiov tasiov commented Jul 25, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch coverage: 87.57% and project coverage change: +11.50% 🎉

Comparison is base (7eb439e) 77.56% compared to head (a788d11) 89.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #13       +/-   ##
===========================================
+ Coverage   77.56%   89.06%   +11.50%     
===========================================
  Files           7       13        +6     
  Lines         156      439      +283     
===========================================
+ Hits          121      391      +270     
- Misses         35       48       +13     
Files Changed Coverage Δ
contracts/fair-burn/src/contract.rs 95.12% <ø> (ø)
contracts/royalty-registry/src/bin/schema.rs 0.00% <0.00%> (ø)
contracts/royalty-registry/src/migrate.rs 0.00% <0.00%> (ø)
packages/sg-index-query/src/lib.rs 70.83% <70.83%> (ø)
contracts/royalty-registry/src/external.rs 81.81% <81.81%> (ø)
contracts/royalty-registry/src/execute.rs 95.06% <95.06%> (ø)
contracts/royalty-registry/src/state.rs 95.45% <95.45%> (ø)
contracts/royalty-registry/src/query.rs 96.00% <96.00%> (ø)
contracts/royalty-registry/src/instantiate.rs 100.00% <100.00%> (ø)
contracts/royalty-registry/src/sudo.rs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tasiov tasiov marked this pull request as ready for review July 26, 2023 17:16
Copy link
Contributor

@yubrew yubrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work. just a few style nitpicks and use max_share_delta when updating shares

packages/sg-index-query/src/lib.rs Show resolved Hide resolved
contracts/royalty-registry/src/bin/schema.rs Show resolved Hide resolved
contracts/royalty-registry/src/helpers.rs Outdated Show resolved Hide resolved
contracts/royalty-registry/src/state.rs Show resolved Hide resolved
contracts/royalty-registry/src/migrate.rs Show resolved Hide resolved
@tasiov tasiov merged commit d5f7be6 into main Aug 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants