Stargaze Fair Burn v1.1.0 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
- Coverage 89.06% 85.68% -3.39%
==========================================
Files 13 17 +4
Lines 439 447 +8
==========================================
- Hits 391 383 -8
- Misses 48 64 +16 ☔ View full report in Codecov by Sentry. |
jhernandezb
approved these changes
Dec 13, 2023
Comment on lines
+72
to
+83
| if recipient.is_some() { | ||
| fee_manager_funds.push(protocol_coin); | ||
| if let Some(dist_coin) = dist_coin { | ||
| recipient_funds.push(dist_coin); | ||
| } | ||
| } else { | ||
| let fee_manager_coin = coin( | ||
| protocol_coin.amount.u128() + dist_coin.map_or(0u128, |c| c.amount.u128()), | ||
| protocol_coin.denom, | ||
| ); | ||
| fee_manager_funds.push(fee_manager_coin); | ||
| } |
There was a problem hiding this comment.
Ok this was a bit confusing maybe should add just a few doc comments
recipient is if there is a dev address to share fairburn right ?
There was a problem hiding this comment.
Yes that's right, typically won't be used for our stuff
MightOfOaks
approved these changes
Dec 16, 2023
shanev
reviewed
Dec 19, 2023
shanev
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fair Burn Changes
This PR implements a
fee_manageraddress in the fair burn contract config. This address will receive the protocol's share of fees for denoms other than STARS.