Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cw721-template #120

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

JakeHartnell
Copy link
Collaborator

Closes #118.

Need to write more contract templates... cargo-generate is pretty cool.

@Art3miX
Copy link
Collaborator

Art3miX commented Jun 9, 2023

I really like the templates idea, while this might seem like not needed, or can be easily achieved by simply copying a folder without generating a template, those sort of small developing improvements are exactly what cosmos is missing.

The only thing I don't like is the fact all of the code is in the lib.rs file, templates should be structurally as similar as possible to a working contract, in my opinion it will be much better to separate the lib.rs file into the corresponding files: errors.rs, msg.rs, contract.rs, tests.rs

@JakeHartnell
Copy link
Collaborator Author

I really like the templates idea, while this might seem like not needed, or can be easily achieved by simply copying a folder without generating a template, those sort of small developing improvements are exactly what cosmos is missing.

The only thing I don't like is the fact all of the code is in the lib.rs file, templates should be structurally as similar as possible to a working contract, in my opinion it will be much better to separate the lib.rs file into the corresponding files: errors.rs, msg.rs, contract.rs, tests.rs

I've been meaning to break it up but haven't found the time yet, that's a really good suggestion. Would be great to upstream a template to sg721 as well.

@Art3miX
Copy link
Collaborator

Art3miX commented Jun 10, 2023

JakeHartnell#1

@elix1er
Copy link

elix1er commented Jul 4, 2023

break it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a template for starting a new basic cw721 project
4 participants