Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for failing edit test on firefox #1551

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

ob6160
Copy link
Member

@ob6160 ob6160 commented Sep 20, 2023

What does this change?

  • Catch spurious errors in our Nominatim location fetch routine which was causing our Firefox Cypress test to fail on the uncaught exception

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
toiletmap ✅ Ready (Inspect) Visit Preview Sep 20, 2023 5:10pm

@github-actions
Copy link

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 206.88 KB (🟡 +5.61 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (200 KB)
/ 12.03 KB 218.91 KB 109.46% (🟢 -0.01%)
/404 534 B 207.4 KB 103.70% (+/- <0.01%)
/500 601 B 207.47 KB 103.73% (+/- <0.01%)
/_error 183 B 207.06 KB 103.53% (+/- <0.01%)
/about 2.22 KB 209.1 KB 104.55% (🟢 -0.01%)
/contact 622 B 207.49 KB 103.74% (+/- <0.01%)
/explorer 1.04 KB 207.92 KB 103.96% (🟢 -0.01%)
/explorer/loos/[id] 15.44 KB 222.31 KB 111.16% (🟡 +0.01%)
/explorer/search 16.58 KB 223.46 KB 111.73% (🟢 -0.10%)
/login 1.49 KB 208.37 KB 104.18% (+/- <0.01%)
/loos/[id] 20.04 KB 226.92 KB 113.46% (🟡 +0.05%)
/loos/[id]/edit 43.15 KB 250.02 KB 125.01% (🟡 +0.03%)
/loos/[id]/remove 14.88 KB 221.76 KB 110.88% (🟡 +0.05%)
/loos/add 42.64 KB 249.52 KB 124.76% (🟡 +0.03%)
/map 699 B 207.56 KB 103.78% (+/- <0.01%)
/privacy 1.42 KB 208.3 KB 104.15% (🟢 -0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@cypress
Copy link

cypress bot commented Sep 20, 2023

Passing run #979 ↗︎

0 63 0 0 Flakiness 0

Details:

Merge 1a7a46a into 884f068...
Project: GBPTM Commit: 7d9c68d79c ℹ️
Status: Passed Duration: 04:15 💡
Started: Sep 20, 2023 5:16 PM Ended: Sep 20, 2023 5:20 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ob6160 ob6160 marked this pull request as ready for review September 20, 2023 17:21
@ob6160 ob6160 self-assigned this Sep 20, 2023
@ob6160 ob6160 added the bug label Sep 20, 2023
Copy link
Contributor

@rosejbon rosejbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@ob6160 ob6160 merged commit 531cc13 into main Sep 20, 2023
23 of 30 checks passed
@ob6160 ob6160 deleted the ob/fix-edit-test branch September 20, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants