Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new Plausible proxy methods #1572

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Update to new Plausible proxy methods #1572

merged 1 commit into from
Oct 29, 2023

Conversation

marxian
Copy link
Collaborator

@marxian marxian commented Oct 3, 2023

We use a same-domain proxy for our Plausible anlytics to reassure
privacy tools that we control our data carefully.

The support for doing this in Plausible changed from DNS level changes
to preferring local proxies. This is well-supported by next-plausible:
https://plausible.io/docs/proxy/guides/nextj

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
toiletmap ✅ Ready (Inspect) Visit Preview Oct 29, 2023 1:28pm

next.config.js Outdated
// eslint-disable-next-line functional/immutable-data
module.exports = withNextAnalyser(moduleExports);
module.exports = withNextAnalyser(withPlausibleProxy(moduleExports));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me @marxian and fixed the build - module.exports = withNextAnalyser(withPlausibleProxy()(moduleExports));

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rosejbon - You're absolutely right.

We use a same-domain proxy for our Plausible anlytics to reassure
privacy tools that we control our data carefully.

THe support for doing this in Plausible changed from DNS level changes
to preferring local proxies. This is well-supported by next-plausible:
https://plausible.io/docs/proxy/guides/nextj
@github-actions
Copy link

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 214.06 KB (🟢 -29 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@cypress
Copy link

cypress bot commented Oct 29, 2023

Passing run #1065 ↗︎

0 63 0 0 Flakiness 0

Details:

Merge 9f1dc04 into 3c7cb01...
Project: GBPTM Commit: bc54133da1 ℹ️
Status: Passed Duration: 02:46 💡
Started: Oct 29, 2023 1:32 PM Ended: Oct 29, 2023 1:35 PM

Review all test suite changes for PR #1572 ↗︎

@marxian marxian merged commit be22665 into main Oct 29, 2023
18 of 20 checks passed
@marxian marxian deleted the plausible-proxy branch October 29, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants