Use a custom cluster marker style #1664
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for toiletmapThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
194.68 KB (🟡 +74 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Passing run #1181 ↗︎
Details:
Review all test suite changes for PR #1664 ↗︎ |
|||||||||||||||
📦 Next.js Bundle Analysis for toiletmapThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
194.68 KB (🟡 +74 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
|
I’ve accepted the Chromatic diffs as they were only changes to the OSM map updates – but there isn’t a story capturing the marker styles. Should I create one? |
If it’s not too much extra effort to chuck in an extra map story with a marker cluster on it there’s no harm IMO. I’m not massively bothered though as it should be quite obvious very quickly when testing if clusters look off if we capture it in Chromatic or not as it’s so core to the experience. Happy either way :) |
I’ve tried a few things, but I’m not understanding how to add marker groups to a story, so I’d prefer getting this in first and possibly improving this as a follow up. |
📦 Next.js Bundle Analysis for toiletmapThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
194.68 KB (🟡 +74 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
sounds good - let's merge it! 👏 first loo map contribution 🚽 |
we no longer differenciate on the number of markers in a group
📦 Next.js Bundle Analysis for toiletmapThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
194.68 KB (🟡 +74 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
mxdvl
added
Chromatic
What does this change?
How was this tested?
How have you tested your changes?
pnpm devAccessibility
If applicable to your changes, have you:
Documentation
If applicable to your changes, have you: