Use light map styles #1668
Closed
Use light map styles #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- free non-commercial API usage - less colourful layer blends better in the background - support for high-DPI / retina displays out of the box
this does not trigger a re-render on every map movement by default, and removes the derived state
a mix of greys, greens and blues, which offers better contrast with the surrounding interface
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for toiletmapThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
194.68 KB (🟡 +1 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
4 failed tests on run #1167 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Adding new toilets to the platform > Desktop > should load the add toilet page successfully for authenticated users |
| |||||||||||||||||||
| Test | Artifacts | |||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Edit page tests > Mobile > should load the edit page with expected data given a valid toilet id |
| |||||||||||||
| Test | Artifacts | |||||||
|---|---|---|---|---|---|---|---|---|
| Adding new toilets to the platform > Mobile > should load the add toilet page successfully for authenticated users |
| |||||||
| Test | Artifacts | |
|---|---|---|
| Remove page tests > Mobile > should remove a toilet successfully when going through the removal flow |
Review all test suite changes for PR #1668 ↗︎ | |
5 tasks
|
Superceded by #1670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
A mix of greys, greens and blues, which offers better contrast with the surrounding interface.
How was this tested?
How have you tested your changes?
Ways of testing could include:
Accessibility
If applicable to your changes, have you:
Documentation
If applicable to your changes, have you: