Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logo to design system #1672

Merged
merged 3 commits into from
May 28, 2024
Merged

Move logo to design system #1672

merged 3 commits into from
May 28, 2024

Conversation

rosejbon
Copy link
Contributor

@rosejbon rosejbon commented May 24, 2024

What does this change?

Small pr to move existing logo to the component into the new design system (needed for the header component).

Documentation

If applicable to your changes, have you:

  • Added/edited the appropriate documentation
  • Added any component(s) to Storybook

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
toiletmap ✅ Ready (Inspect) Visit Preview May 24, 2024 4:11pm

Copy link

📦 Next.js Bundle Analysis for toiletmap

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 197.07 KB (🟡 +2.39 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@rosejbon rosejbon added the Chromatic starts the Chromatic GitHub action workflow label May 24, 2024
Copy link

cypress bot commented May 24, 2024

Passing run #1187 ↗︎

0 63 0 0 Flakiness 0

Details:

Merge ed46c3b into a1b4e94...
Project: GBPTM Commit: c6ec269c96 ℹ️
Status: Passed Duration: 02:01 💡
Started: May 24, 2024 4:16 PM Ended: May 24, 2024 4:18 PM

Review all test suite changes for PR #1672 ↗︎

Copy link
Member

@ob6160 ob6160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, love seeing the design system growing 🎨

@rosejbon rosejbon merged commit 2f03ff8 into main May 28, 2024
22 checks passed
@rosejbon rosejbon deleted the move-logo-to-design-system branch May 28, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromatic starts the Chromatic GitHub action workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants