Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove firefox from our ci pipeline #1717

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Remove firefox from our ci pipeline #1717

merged 1 commit into from
Sep 24, 2024

Conversation

ob6160
Copy link
Member

@ob6160 ob6160 commented Sep 23, 2024 •
edited
Loading

What does this change?

  • We're doubling up our end to end tests for both Chrome and Firefox for arguably minimal gains. Firefox is a modern browser and if the tests pass against Chrome it's very likely the application will be working against Firefox too.
  • It means I get to remove lines of code 😈
  • We're less likely to experience e2e test flake + we can remove some skipped tests on FF / setup quirks

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
toiletmap ✅ Ready (Inspect) Visit Preview Sep 24, 2024 8:24am

@ob6160 ob6160 marked this pull request as ready for review September 23, 2024 21:35
@cypress Cypress
Copy link

cypress bot commented Sep 23, 2024 •
edited
Loading

GBPTM    Run #1299

Run Properties:  status check passed Passed #1299  •  git commit 9d723bde53 ℹ️: Merge d19a887cc8c2e23f4ea7930e004e1fd00202f76e into cd47589d62ae1858b8b07b5953e1...
Project GBPTM
Branch Review refs/pull/1717/merge
Run status status check passed Passed #1299
Run duration 03m 46s
Commit git commit 9d723bde53 ℹ️: Merge d19a887cc8c2e23f4ea7930e004e1fd00202f76e into cd47589d62ae1858b8b07b5953e1...
Committer Oliver Barnwell
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 63
View all changes introduced in this branch ↗︎

marxian
marxian approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@marxian marxian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree...

It is unlikely that this extra coverage provides extra confidence in our situation.

@ob6160 ob6160 merged commit b2d6c58 into main Sep 24, 2024
2 of 7 checks passed
@ob6160 ob6160 deleted the ob/remove-firefox-checks branch September 24, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marxian marxian marxian approved these changes

@mxdvl mxdvl Awaiting requested review from mxdvl

@Hoolean Hoolean Awaiting requested review from Hoolean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob6160 @marxian