Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail the build if we have type errors (and fix/ignore remaining errors) #1723

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Fail the build if we have type errors (and fix/ignore remaining errors) #1723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
164677b
type all of the things
ob6160 Sep 23, 2024
6eaed9f
make getIcon private
ob6160 Oct 6, 2024
616b64a
simplify places where we parseInt
ob6160 Oct 6, 2024
58532c9
destructure width and height, use as const
ob6160 Oct 6, 2024
df92e29
use URLSearchParams to simplify nominatim URL construction
ob6160 Oct 6, 2024
ec76e5d
use 'satisfies'
ob6160 Oct 6, 2024
ba1d4c3
remove unnecessary argument
ob6160 Oct 6, 2024
79ea338
update types for terminatingLink
ob6160 Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
explorer-old
!.storybook
src/api-client
!src/api-client/withApollo.tsx
src/api-client/graphql.tsx
src/api-client/page.tsx
ob6160 marked this conversation as resolved.
Show resolved Hide resolved
src/api/db
src/api/directives
src/@types/resolvers-types.ts
7 changes: 0 additions & 7 deletions next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,6 @@
**/
const moduleExports = {
reactStrictMode: true,
typescript: {
// !! WARN !!
// Dangerously allow production builds to successfully complete even if
// your project has type errors.
// !! WARN !!
ignoreBuildErrors: true,
},
Comment on lines -6 to -12
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

transpilePackages: [
'@react-leaflet/core',
'react-leaflet',
Expand Down
93 changes: 43 additions & 50 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading