Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set gh actions cypress action to v6 #1727

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Set gh actions cypress action to v6 #1727

merged 1 commit into from
Oct 6, 2024

Conversation

ob6160
Copy link
Member

@ob6160 ob6160 commented Oct 6, 2024 •
edited
Loading

What does this change?

  • We've been having persistent issues with our Cypress binary cache not being persisted properly across CI runs, hopefully this will resolve the issue after bumping the version of the Cypress gh action that we use to v6
  • Maybe it won't, maybe it will : -)

@vercel Vercel
Copy link

vercel bot commented Oct 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
toiletmap ✅ Ready (Inspect) Visit Preview Oct 6, 2024 4:11pm

@ob6160 ob6160 marked this pull request as ready for review October 6, 2024 16:15
@cypress Cypress
Copy link

cypress bot commented Oct 6, 2024

GBPTM    Run #1334

Run Properties:  status check passed Passed #1334  •  git commit f658b0d65f ℹ️: Merge 331b7f5151d51a0ce7de22447119c33f98e1c860 into 4a92dcd6b491621f93a3355a7f08...
Project GBPTM
Branch Review refs/pull/1727/merge
Run status status check passed Passed #1334
Run duration 01m 43s
Commit git commit f658b0d65f ℹ️: Merge 331b7f5151d51a0ce7de22447119c33f98e1c860 into 4a92dcd6b491621f93a3355a7f08...
Committer Oliver Barnwell
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 63
View all changes introduced in this branch ↗︎

Hoolean
Hoolean approved these changes Oct 6, 2024
View reviewed changes
Copy link
Collaborator

@Hoolean Hoolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're well due on upgrade in either case 🚀

I checked the action's CHANGELOG and it looks like the main breaking changes were major Node version bumps; we're on 20 now, which is the current LTS, and so we should be fine here :)

@ob6160
Copy link
Member Author

ob6160 commented Oct 6, 2024

Thanks for checking @Hoolean :)

@ob6160 ob6160 merged commit 9a8e4c3 into main Oct 6, 2024
16 checks passed
@ob6160 ob6160 deleted the ob/update-cypress-gh-action branch October 6, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoolean Hoolean Hoolean approved these changes

@mxdvl mxdvl Awaiting requested review from mxdvl

@marxian marxian Awaiting requested review from marxian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ob6160 @Hoolean