Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Adding HTML and images for new Codebase pages on publiccode.net #100

Closed
wants to merge 10 commits into from

Conversation

angelplasma
Copy link
Member

@angelplasma angelplasma commented Sep 10, 2020

These will replace the currently live .md files for the Codebase index, and OpenZaak and Signalen details pages

There are two accompanying CSS files (publiccodenet/jekyll-theme#42)

  1. Codebases Style - Isolated in a separate SCSS file (see question below)
  2. Lightbox - Also contained its own (standard) CSS file

This closes issue #64


Questions/issues:

  1. CSS vs SCSS - The linked SCSS of course needs to be com/transpiled. If this is feasible, how can I facilitate? If necessary, I can simply upload the rendered CSS (and if there is an impasse, I can permanently shift to standard CSS, and avoid SCSS altogether).
  2. Jekyll/HTML header structure - The new HTML files need to call the aforementioned (S)CSS files. Right now this is done via standard HTML head tag, but I'm aware this extra HTML formatting is not proper for the Jekyll set up.

I'm sure there will be other issues. Thank you for your patience in iterating on this with me!


View rendered codebases/openzaak.md
View rendered codebases/signalen.md

@ElenaFdR
Copy link
Member

@bvhme questions: do these pages have the header and the footer? what about Jekyll's templating system for the codebase overview pages?

<div>
<h1 class="title">Our Codebases</h1>
<h4 class="subtitle"><p>The Foundation for Public Code supports ambitious communities and their codebases to scale effectively, including smoother collaboration and shared governance.</p>
<p>Codebases are organized by their <a href="/codebase-stewardship/lifecycle.html">codebase maturity.</a></p></h4>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>Codebases are organized by their <a href="/codebase-stewardship/lifecycle.html">codebase maturity.</a></p></h4>
<p>Codebases are organized by their <a href="https://about.publiccode.net/activities/codebase-stewardship/lifecycle.html">codebase maturity.</a></p></h4>

@ElenaFdR
Copy link
Member

ElenaFdR commented Nov 6, 2020

This PR has been superseded by #110 and #111.

@ElenaFdR ElenaFdR closed this Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants