Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading of Images only #329

Closed
grvsachdeva opened this issue Feb 7, 2019 · 6 comments
Closed

Allow uploading of Images only #329

grvsachdeva opened this issue Feb 7, 2019 · 6 comments

Comments

@grvsachdeva
Copy link
Member

Although, the goal of Mapknitter is clear that images should be uploaded to make the map but for to take care of our database and spam, we should limit uploading of only images.

I tried uploading mp4 file and to surprise no error was thrown. So, we need to fix the accept type of file.

Thanks!

@IshaGupta18
Copy link

I think changing this line:

<i class="fa fa-plus-circle"></i> Select images <input id="warpable_uploaded_data" name="warpable[uploaded_data]" type="file" multiple />

to this line is doing the trick:

<i class="fa fa-plus-circle"></i> Select images <input id="warpable_uploaded_data" name="warpable[uploaded_data]" type="file" accept="image/*" />

Only image file options will be displayed from the user's file system:

image

Should I make a PR for this @gauravano @jywarren ?

@grvsachdeva
Copy link
Member Author

Hi @IshaGupta18, you have surely solved the issue. You can raise a PR or open a first-timer-issue too, however you like. Thanks 😃

@IshaGupta18
Copy link

I would love to open an FTO! Thanks a lot @gauravano !

@IshaGupta18
Copy link

Hey @gauravano I have created FTO #338 however I don't have the privileges I haave in plots2, like adding labels. Could you please grant me those privileges here as well or add fto label to it? Thanks a lot!

@grvsachdeva
Copy link
Member Author

Thank you so much @IshaGupta18! I checked but I am not privileged to give you write permission required to add labels to the repo. But, let's ask @jywarren. For now, I am labeling the issue. Thanks!

@grvsachdeva
Copy link
Member Author

Closing this one as FTO opened at #338. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants