fix: Filter out empty Str nodes without stripping trailing spaces

pubpub · Jul 20, 2022 · 42d5eac · 42d5eac
1 parent 0f4765a
commit 42d5eac
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 5 deletions.
diff --git a/src/transform/fromProsemirror/__tests__/fromProsemirror.test.ts b/src/transform/fromProsemirror/__tests__/fromProsemirror.test.ts
@@ -79,6 +79,21 @@ describe("fromProsemirror", () => {
         ]);
     });
 
+    it("transforms a string with trailing spaces", () => {
+        expect(
+            fromProsemirror(
+                { type: "text", text: "Hello world " },
+                rules
+            ).asArray()
+        ).toEqual([
+            { type: "Str", content: "Hello" },
+            { type: "Space" },
+            { type: "Str", content: "world" },
+            { type: "Space" },
+        ]);
+    });
+
+
     it("performs a simple transformation from Prosemirror marks to nodes", () => {
         expect(
             fromProsemirror(

diff --git a/src/transform/util.ts b/src/transform/util.ts
@@ -37,12 +37,14 @@ export const intersperse = (
 
 export const textToStrSpace = (text: string): (Str | Space)[] =>
     intersperse(
-        text
-            .split(" ")
-            .filter((word) => word.length > 0)
-            .map((word) => ({ type: "Str", content: word })),
+        text.split(" ").map((word) => ({ type: "Str", content: word })),
         () => ({ type: "Space" })
-    );
+    ).filter((node) => {
+        if (node.type === "Str" && node.content.length === 0) {
+            return false;
+        }
+        return true;
+    });
 
 export const asArray = <T>(item: T | T[]): T[] => {
     return Array.isArray(item) ? item : [item];