-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: really support not receiving refresh token #10
base: master
Are you sure you want to change the base?
Conversation
The previous attempt would still crash if the key was not in the dict at all (as seems to be the case with recent mediawiki), so we need to handle that too. Signed-off-by: Adam Williamson <awilliam@redhat.com>
hmm, still not sure this is the whole story. after applying this patch, instead of crashing because
on the other we get the "no refresh token present" debug line and then a similar traceback:
don't have time to dig further into it today, just mentioning it here so I don't forget about it... |
The previous attempt would still crash if the key was not in the
dict at all (as seems to be the case with recent mediawiki), so
we need to handle that too.
Signed-off-by: Adam Williamson awilliam@redhat.com