Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update confluence links #975

Merged
merged 4 commits into from
Jan 29, 2024
Merged

update confluence links #975

merged 4 commits into from
Jan 29, 2024

Conversation

lizgarciao
Copy link
Contributor

closes #952

@lizgarciao lizgarciao requested review from sandbergja, christinach and rladdusaw and removed request for rladdusaw December 3, 2023 04:03
@lizgarciao lizgarciao marked this pull request as draft December 3, 2023 06:03
@lizgarciao
Copy link
Contributor Author

lizgarciao commented Dec 3, 2023

@christinach @sandbergja There are three failures with the rspec because of the change in the links (it expects the old link). I did a global search with command+shift+F in vscode but could not find the correspoding rspec files where these tests are failing.

Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizgarciao ! Here's a suggestion about how to address those test failures.

spec/mailers/approve_request_mailer_spec.rb Outdated Show resolved Hide resolved
spec/mailers/approve_request_mailer_spec.rb Outdated Show resolved Hide resolved
christinach and others added 2 commits December 12, 2023 09:36
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
Co-authored-by: Jane Sandberg <sandbergja@users.noreply.github.com>
@christinach christinach marked this pull request as ready for review December 12, 2023 14:38
Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lizgarciao ! 😃

@christinach christinach merged commit 8d21590 into main Jan 29, 2024
9 of 10 checks passed
@christinach christinach deleted the update-confluence-links branch January 29, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update confluence links
4 participants