Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several lux grids should actually be lux data tables #179

Open
3 tasks
sandbergja opened this issue Feb 13, 2023 · 0 comments
Open
3 tasks

Several lux grids should actually be lux data tables #179

sandbergja opened this issue Feb 13, 2023 · 0 comments

Comments

@sandbergja
Copy link
Member

Current display

The following screens use the lux grid component to present tabular data.

Desired display

Using a data-table instead would provide several benefits:

  • screen reader users could navigate the table using the table controls. Presenting tabular data without tabular markup is a WCAG 1.3.1 failure, so I'm adding the accessibility-A label.
  • each row would not be announced as an "article" by voiceover
  • data-table comes with column sorting controls
  • less repetition in the UI
  • better semantics

Acceptance criteria

  • Each page above uses a <data-table> instead of a <grid>
  • I can successfully use these keyboard commands to navigate these tables using Voice Over in Safari.
  • I have checked these pages using one of the following browser extensions and confirmed that migrating to a data-table does not add any level A or level AA issues:
    • axe dev tools
    • Lighthouse
    • Wave

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants