Invalid UID for user in production

[maxkadel]

Expected behavior

All users in production have valid UIDs which can be used to generate emails.

Actual behavior

There is one user in production whose UID includes @gmail.com, which creates an error when we try to generate emails.

Steps to replicate

1. ssh onto the production server as deploy ssh deploy@lockers-and-study-spaces-prod2
2. cd into the current directory cd /opt/lockers_and_study_spaces/current
3. Go into the rails console bundle exec rails c
4. Find user 603 u = User.find(603)
5. Look at the user's uid u.uid and notice that it includes @gmail.com

Impact of this bug

Every time we try to send an email to all users we get an error and have to revisit this.

Honeybadger link and code snippet, if applicable

Honeybadger link

Net::SMTPFatalError: 553 5.1.3 <romeroschloss@gmail.com@princeton.edu>... Invalid route address
def check_response(res)
  unless res.success?
    raise res.exception_class.new(res)
  end
end

Implementation notes, if any

• We have tried to address this previously with Invalid email addresses cause an error #233.
• The user was created with the original migration and has not been updated since. Can we either delete this user, or change their uid to remove the @gmail.com?
• If the user has not accessed the application recently delete them, and update the email if they have been active.