Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused partial _advanced_navbar.html.erb #3871

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Delete unused partial _advanced_navbar.html.erb #3871

merged 1 commit into from
Dec 4, 2023

Conversation

christinach
Copy link
Member

closes #3757

@coveralls
Copy link

Coverage Status

coverage: 95.405%. remained the same
when pulling 6ffc681 on 3757-cleanup
into 7ae7bad on main.

kevinreiss
kevinreiss approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@kevinreiss kevinreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting this bug is also present in this branch: #3874. It's unrelated to the change here.

@kevinreiss kevinreiss merged commit 3b8dddb into main Dec 4, 2023
10 checks passed
@kevinreiss kevinreiss deleted the 3757-cleanup branch December 4, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinreiss kevinreiss kevinreiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if we still need the shared/_advanced_navbar partial
3 participants
@christinach @coveralls @kevinreiss