Generated Docker Image - Build on PR #1389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a docker-compose file, and I just added solr to it.
I'm still not convinced.
tpendragon
force-pushed
the
docker_generated
branch
from
da2e798 to
29f6190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is generating Docker via https://github.com/fly-apps/dockerfile-rails
The command after installing the gem is:
rails g dockerfile --parallel --nginx --compose- I only added Solr to the docker-compose, fixed a pids problem, removed.yarn, and Pulfalight was building a prod-ready container.Much of the customization was to get
docker-composeto work, which seemed useful for testing the image locally.