refactoring #approve_project (#641)

* refactoring #approve_project

* Update spec/models/project_metadata_spec.rb

Co-authored-by: carolyncole <1599081+carolyncole@users.noreply.github.com>

---------

Co-authored-by: carolyncole <1599081+carolyncole@users.noreply.github.com>

app/controllers/projects_controller.rb

@@ -120,8 +120,6 @@ def update
     project
     #Approve action
     if params.key?("mediaflux_id")
-      project.mediaflux_id = params["mediaflux_id"]
-      project.metadata_json["status"] = Project::APPROVED_STATUS
       project_metadata = ProjectMetadata.new(project: project, current_user:)
       project_params = params.dup
       project_metadata.approve_project(params: project_params)

app/models/project_metadata.rb

@@ -15,6 +15,12 @@ def update_metadata(params:)
   end
 
   def approve_project(params:)
+    #approve a project by recording the mediaflux id & setting the status to 'approved' 
+    project.mediaflux_id = params[:mediaflux_id]
+    project.metadata_json["status"] = Project::APPROVED_STATUS
+    project.save!
+
+    #create two provenance events, one for approving the project and another for changing the status of the project
     project.provenance_events.create(event_type: ProvenanceEvent::APPROVAL_EVENT_TYPE, event_person: current_user.uid, event_details: "Approved by #{current_user.display_name_safe}")
     project.provenance_events.create(event_type: ProvenanceEvent::STATUS_UPDATE_EVENT_TYPE, event_person: current_user.uid, event_details: "The Status of this project has been set to approved")
   end

spec/models/project_metadata_spec.rb

@@ -145,6 +145,16 @@
     end
 
     describe "#approve_project" do
+    it "Records the mediaflux id and sets the status to approved" do 
+      project_metadata = described_class.new(current_user: current_user, project:)
+      params = {mediaflux_id: 001 }
+      project_metadata.approve_project(params:)
+
+      project.reload
+
+      expect(project.mediaflux_id).not_to be_nil
+      expect(project.metadata_json["status"]).to eq Project::APPROVED_STATUS
+    end
     it "Creates a Provenance Event: Approval" do
       project_metadata = described_class.new(current_user: current_user, project:)
       params = {data_sponsor: "abc", data_manager: "def", departments: "dep", directory: "dir", title: "title abc", description: "description 123" }