Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a space themed preloader #14

Open
pulkithanda opened this issue Sep 21, 2021 · 10 comments
Open

Adding a space themed preloader #14

pulkithanda opened this issue Sep 21, 2021 · 10 comments

Comments

@pulkithanda
Copy link
Owner

pulkithanda commented Sep 21, 2021

Issue picture

Adding a space themed preloader for this website

You may use the following link for your reference:

https://codepen.io/chrisgannon/pen/OwQyag

For further Issues contact below or use my discord to contact me Alphabet# 0352

@nshanbhag20001412
Copy link

Hey, I want to work on this issue. Please assign it to me.

@pulkithanda
Copy link
Owner Author

Hey there! Sure go ahead, Assigned the issue to you ^_^

@nshanbhag20001412
Copy link

nshanbhag20001412 commented Sep 24, 2021

Hey where should I add the preloader's html file? . I'm thinking of adding the css content to main.css . Should I place the html(preloader.html) file in static or in templates folder?. Should i create a different css file for it or adding it to main.css is fine?

Edit: Created a preloader file consisting of html and css file for the preloader animation
, if its fine , and after you approve ill raise a PR in october https://github.com/nshanbhag20001412/voyager-hf
image

@pulkithanda
Copy link
Owner Author

pulkithanda commented Sep 24, 2021

Hey! I cloned your repo but can't see the preloader in effect. but as for the files well the static folder contains the CSS and js files whereas the "template" folder contains all the HTML files. Since this is flask it's a bit different I must tell you in flask the common file is a layout.html file, it contains the common elements for all the pages instead of adding it again and again for eg it has the navbar which is common to all so the preloader should go there as well. Remember to insert the code between body and {% block content %}{% endblock %}. I may be confusing as you are a first timer with flask? You can contact me on my discord Alphabet# 0352 for further queries. By the screenshot, the preloader looks great.

@nshanbhag20001412
Copy link

nshanbhag20001412 commented Sep 25, 2021

Okay yeah , I'm not familiar with flask I'll check that out. Also couldn't connect you through discord, I guess something is missing (the fourth digit).

I moved my "preloader.html" to "templates" and since preloader's css is large instead of adding it to the main css moved "preloader.css" to static and linked it in layout.html(replicating to the link of main.css).

Now, what do you want me to do from the following :

  1. Copy the html content of preloader between the {% block content %} //content {% endblock %} of layout.html and delete "preloader.html" from the 'templates'
  2. Keep the html of preloader in 'preloader.html' and edit it just like the other html pages in templates.
    {% extends "layout.html" %} {% block content %} //content excluding common elements {% endblock content %}

I'm assuming the first one, after reading your message.

Looking forward to learn from you!

@pulkithanda
Copy link
Owner Author

pulkithanda commented Sep 25, 2021

Hey! I have updated my discord (see the issue), GitHub took # 0 and omitted 0. Anyways I have updated it. As for the issue moving your files in templates and static is good enough. You can do 1 as I explained earlier layout.html contains the common elements which are common to all the HTML's without that how do you plan to display the preloader.html in all of those HTML files? You can do it either way as you feel comfortable but make sure it is displayed on every HTML page. That's it.

@pulkithanda
Copy link
Owner Author

Any updates yet @nshanbhag20001412 ?

@nshanbhag20001412
Copy link

i was busy these days i tried couldnt do it :(

@pulkithanda
Copy link
Owner Author

@nshanbhag20001412 What part exactly I told you how it worked? if you couldn't reduce the size leave it push the rest ?

@nshanbhag20001412
Copy link

due to my college work im not able to spare time, im sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants