-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a space themed preloader #14
Comments
Hey, I want to work on this issue. Please assign it to me. |
Hey there! Sure go ahead, Assigned the issue to you ^_^ |
Hey where should I add the preloader's html file? . I'm thinking of adding the css content to main.css . Should I place the html(preloader.html) file in static or in templates folder?. Should i create a different css file for it or adding it to main.css is fine? Edit: Created a preloader file consisting of html and css file for the preloader animation |
Hey! I cloned your repo but can't see the preloader in effect. but as for the files well the static folder contains the CSS and js files whereas the "template" folder contains all the HTML files. Since this is flask it's a bit different I must tell you in flask the common file is a layout.html file, it contains the common elements for all the pages instead of adding it again and again for eg it has the navbar which is common to all so the preloader should go there as well. Remember to insert the code between body and {% block content %}{% endblock %}. I may be confusing as you are a first timer with flask? You can contact me on my discord Alphabet# 0352 for further queries. By the screenshot, the preloader looks great. |
Okay yeah , I'm not familiar with flask I'll check that out. Also couldn't connect you through discord, I guess something is missing (the fourth digit). I moved my "preloader.html" to "templates" and since preloader's css is large instead of adding it to the main css moved "preloader.css" to static and linked it in layout.html(replicating to the link of main.css). Now, what do you want me to do from the following :
I'm assuming the first one, after reading your message.Looking forward to learn from you! |
Hey! I have updated my discord (see the issue), GitHub took # 0 and omitted 0. Anyways I have updated it. As for the issue moving your files in templates and static is good enough. You can do 1 as I explained earlier layout.html contains the common elements which are common to all the HTML's without that how do you plan to display the preloader.html in all of those HTML files? You can do it either way as you feel comfortable but make sure it is displayed on every HTML page. That's it. |
Any updates yet @nshanbhag20001412 ? |
i was busy these days i tried couldnt do it :( |
@nshanbhag20001412 What part exactly I told you how it worked? if you couldn't reduce the size leave it push the rest ? |
due to my college work im not able to spare time, im sorry |
Issue picture
Adding a space themed preloader for this website
You may use the following link for your reference:
https://codepen.io/chrisgannon/pen/OwQyagFor further Issues contact below or use my discord to contact me Alphabet# 0352
The text was updated successfully, but these errors were encountered: