Add correct logic for new templated nginx file #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gerrod3 galaxy's oci setups are broken without this patch ... do you plan to take it out of WIP soon and merge? |
|
@jctanner can you unblock galaxy by selecting a known to work base image tag? |
|
@mdellweg yes, but as soon as this PR is merged, we'll have to change it again. |
Sure, it's only a stop gap. But I basically wanted to know if we are in the position to workaround such environmental dependencies. Great to hear we are. |
jctanner
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this new feature being added to the ci-centos image: pulp/pulp-oci-images#623