Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python3-createrepo_c and remove some build dependencies #506

Closed
decko opened this issue Jun 14, 2023 · 8 comments
Closed

Use python3-createrepo_c and remove some build dependencies #506

decko opened this issue Jun 14, 2023 · 8 comments
Labels

Comments

@decko
Copy link
Member

decko commented Jun 14, 2023

After reading the following note from our Containerfile.core.base manifest

# The last 5 lines (before clean) are needed until python3-createrepo_c gets an
# RPM upgrade to 0.16.2. Until then, we install & build it from PyPI.

I went to https://pkgs.org/download/python3-createrepo_c website just to discover that CentOS8 Stream have the version cited in the note.

So, I'm proposing a review of the packages installed into our core image for building and use Pulp.

@mikedep333
Copy link
Member

Confirm with @dralley

@dralley
Copy link
Contributor

dralley commented Jun 20, 2023

We can't use the version in CentOS 8 stream, the comment is a bit out of date, we require a newer version than that.

CentOS 9 stream should work, I think. But it does remove some flexibility as in the future we will need to wait for the package to be updated before using new functionality, or receiving bugfixes. In general I think that might be perfectly OK, just be aware of the tradeoff.

@mikedep333
Copy link
Member

@dralley Yeah, the version in CentOS 8 Stream is 0.17.7.

I'd like to update the comment. What version is needed?

@dralley
Copy link
Contributor

dralley commented Jun 20, 2023

0.20.0 is the minimum I believe.

@decko
Copy link
Member Author

decko commented Aug 2, 2023

When we install the python3-createrepo_c package seems that it install the dependencies needed for the build of the createrepo_c package from pypi. With that we can remove the build dependencies and yet keep installed the createrepo_c version from pypi.

What do you think @dralley?

@dralley
Copy link
Contributor

dralley commented Aug 2, 2023

Not if the dependencies change between versions, which they do occasionally. Better to just use an explicit list.

If we update the base image then we can just use the package, but otherwise we shouldn't mix and match.

@dralley
Copy link
Contributor

dralley commented Aug 8, 2023

@decko What's the blocker on just updating the base image? EL9 isn't really bleeding edge anymore.

@decko
Copy link
Member Author

decko commented Aug 22, 2023

I'm gonna close this in favor of #537

@decko decko closed this as completed Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants