-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #526 BUGFIX - Postgres init - Only match first major number of postgres #522
Conversation
`postgres --version` returns: postgres (PostgreSQL) 13.10 Which the regex matches both the 13 and the 10 and caused postgres init to attempt to update the database version and then fail.
Hi @clickthisnick , To fix our CI: Please add this to the end of your commit message:
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
@@ -13,7 +13,7 @@ export C035="\e[35m" | |||
export C036="\e[36m" | |||
export C037="\e[37m" | |||
|
|||
PGVERSION=$(postgres --version | egrep -o "1[0-9]") | |||
PGVERSION=$(postgres --version | egrep -o "1[0-9]" | head -n1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work to?
PGVERSION=$(postgres --version | egrep -o "1[0-9]" | head -n1) | |
PGVERSION=$(postgres --version | egrep -m 1 -o "1[0-9]") |
This pull request is no longer marked for closure. |
1 similar comment
This pull request is no longer marked for closure. |
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
#526
I'm testing this with a base image of redhat 8.6 - everything works once I modify this line.
postgres --version
returns:postgres (PostgreSQL) 13.10
Which the regex matches both the 13 and the 10 and caused postgres init to attempt to update the database version and then fail. Postgres doesn't ever come up and thus pulp doesn't work.
Once I use
| head -n1
to get get the13
and not the additional10
in the postgres version, everything works.Using regexr