Use django to check db connection #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
rework_wait_for_db
branch
2 times, most recently
from
6603266
to
71220c7
Compare
[noissue]
mdellweg
force-pushed
the
rework_wait_for_db
branch
from
71220c7
to
6b8d59d
Compare
mikedep333
approved these changes
Sep 1, 2023
| import sys | ||
| import time | ||
| from django.db import connection, utils |
| @@ -51,8 +51,6 @@ services: | |||
| - "./assets/certs:/etc/pulp/certs:z" | |||
| - "../../pulp_storage:/var/lib/pulp:z" | |||
| environment: | |||
| POSTGRES_SERVICE_PORT: 5432 | |||
There was a problem hiding this comment.
I see these are not necessary because they're in the settings.py file. 👍🏻
There was a problem hiding this comment.
Actually it was only used by the old wait_on_postgres.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]