Configure SSL if variable is capitalized or not #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
requested changes
Sep 27, 2023
images/s6_assets/init/nginx
Outdated
| @@ -1,6 +1,6 @@ | |||
| #!/bin/bash | |||
|
|
|||
| if [ "${PULP_HTTPS}" = "true" ]; then | |||
| if [[ "${PULP_HTTPS}" = "true" || "${PULP_HTTPS}" = "True" ]]; then | |||
There was a problem hiding this comment.
Suggested change
| if [[ "${PULP_HTTPS}" = "true" || "${PULP_HTTPS}" = "True" ]]; then | |
| if [ "${PULP_HTTPS,,}" = "true" ]; then |
I am +1 for making the matching less strict.
But you should probably not define your environment variables with bool in the first place.
Yaml does not like Norway...
|
Instead of closing, the PR, would you be willing to apply the suggestion and we can merge it? |
|
@mdellweg OK I reopened the PR and did the change. |
mdellweg
approved these changes
Sep 28, 2023
tinsjourney
force-pushed
the
podman_container
branch
from
72df51c
to
a3e96e7
Compare
|
Can you please squash to commits into one? |
tinsjourney
force-pushed
the
podman_container
branch
from
a3e96e7
to
ca868c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ansible-podman-collections to create the multi-process images, boolean environment are capitalized.
So this is workaround until
containers/ansible-podman-collections#648 is fixed.