Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds for multiarch #562

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

StopMotionCuber
Copy link
Contributor

This is providing fixes for multiarch builds. I've hardcoded the desired architectures at some places, this could probably be streamlined in case wanted.

I've excluded ppc64le, as it had various issues with dependencies for pip install pulpcore, of which pip install grpcio was not fixable. There was an additional error with pyyaml in version 6.0, but this is fixed in 6.0.1 where some version pinning while building would probably have worked.

The GitHub Actions run went mostly fine and only complained about the docker login (which obviously doesn't work without credentials)

@StopMotionCuber
Copy link
Contributor Author

Ah, PR linting failing again cause of changelog building automation and stuff.

Would be nice if a maintainer could get back to me with the preferred way of handling that. Squash commits + open a ticket + add that to Changes/XXX.bugfix? [noissue] to all commits? Squash and [noissue] for that single commit?

@lubosmj
Copy link
Member

lubosmj commented Nov 20, 2023

To unblock you, try squashing all the commits and adding "[noissue]" to the commit description:

git commit -m "Blabla" -m "[noissue]"

We can later decide on whether to open a new issue or not...

@StopMotionCuber
Copy link
Contributor Author

Done, commits are squashed now

@mdellweg
Copy link
Member

Any explanation, why the PR was green, while the nightly builds stopped working here?

@StopMotionCuber
Copy link
Contributor Author

Any explanation, why the PR was green, while the nightly builds stopped working here?

From my side I'm not sure about that. My experience with GitHub, especially GitHub Actions and their checking is limited, have more experience with GitLab.

Especially I'm seeing only 2 passing checks on #546 while there are 11 on this PR. Not sure if the image build was not done or the history is just confusing...?
Anyway, it has probably built something which is why the light turned green

@hstct
Copy link

hstct commented Nov 22, 2023

Currently I'm unable to build any other architecture than arm64 using the latest images. podman seems to ignore any options to force the platform to amd64. Hopefully this issue will fix this issue?

@lubosmj lubosmj merged commit f289b02 into pulp:latest Nov 22, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants