-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop createrepo_c build deps #589
base: latest
Are you sure you want to change the base?
Conversation
Oh, right, we can't do this until we upgrade to Python 3.9, because createrepo_c doesn't publish wheels for 3.8 |
@@ -45,15 +39,7 @@ RUN dnf -y install python3 python3-cryptography python3-devel && \ | |||
dnf -y install python3-libcomps && \ | |||
dnf -y install libpq-devel && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we remember what this is required for? And openldap-devel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cb44bff
to
62e36a9
Compare
@mikedep333 I think this is failing because we're building aarch64 images now, but the binary packages don't exist for createrepo_c, solv, and maybe libcomps, so it falls back to trying to build from source. I guess the only alternatives are qemu, or waiting until GHA has ARM runners available. |
c4d3ec3
to
18b2c98
Compare
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
We use the prebuilt wheels nowadays [noissue]
And look what we got https://github.blog/2024-06-03-arm64-on-github-actions-powering-faster-more-efficient-build-systems/ |
But not on free plans yet. And older branches use older versions of createrepo_c and libcomps and such, for which no binary arm packages are uploaded, so we might have to wait a bit for some of those to phase out. |
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
We use the prebuilt wheels nowadays
[noissue]