Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors #658

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix CI errors #658

merged 1 commit into from
Aug 21, 2024

Conversation

git-hyagi
Copy link
Contributor

@git-hyagi git-hyagi commented Aug 20, 2024

  • Remove deprecated "update-ca-trust force-enable" call
  • Create the /var/run/postgresql directory. In older versions
    of postgresql-server package, this directory was created during
    package installation. The newer versions are not creating it
    anymore (because systemd was supposed to do it) which is breaking
    our s6 based images.
  • Change a Containerfile RUN instruction to run dnf once (not a fix,
    just a little improvement)

[noissue]

Comment on lines 25 to 30
RUN dnf -y install postgresql-13.14-1.el9 \
postgresql-contrib-13.14-1.el9 \
postgresql-server-13.14-1.el9 \
postgresql-upgrade-13.14-1.el9 \
nginx \
redis && \
Copy link
Member

@lubosmj lubosmj Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still seeing these lines in the logs:

2024-08-20T20:37:34.7605844Z [oneshot] postgres-init: �[33m Postgresql database exists but will be upgraded from 12 to 13�[0m
2024-08-20T20:37:34.7606104Z Creating directory /var/lib/pulp/scripts
2024-08-20T20:37:34.7606359Z Checking /var/lib/pulp/scripts permissions
2024-08-20T20:37:34.7607173Z [oneshot] fix-pulp-perms: �[32mchown -R pulp:pulp /var/lib/pulp/scripts�[0m
2024-08-20T20:37:34.7607412Z Checking /var/lib/pulp/tmp permissions
2024-08-20T20:37:34.7607967Z [oneshot] fix-pulp-perms: �[32mchown -R pulp:pulp /var/lib/pulp/tmp�[0m
2024-08-20T20:37:34.7608969Z s6-rc: info: service fix-pulp-perms successfully started
2024-08-20T20:37:34.7610554Z waiting for server to start....2024-08-20 20:21:18.220 UTC [125] LOG:  starting PostgreSQL 12.18 on x86_64-redhat-linux-gnu, compiled by gcc (GCC) 11.4.1 20231218 (Red Hat 11.4.1-3), 64-bit

Where is actually the postgresql13 installed? 🍭

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, oh, I was looking at different logs. It is right there.

2024-08-21T09:20:54.4256309Z STEP 13/23: RUN dnf -y install postgresql-13.14-1.el9       postgresql-contrib-13.14-1.el9       postgresql-server-13.14-1.el9       postgresql-upgrade-13.14-1.el9       nginx       redis &&     dnf clean all
2024-08-21T09:20:57.3196275Z CentOS Stream 9 - BaseOS                         11 MB/s | 9.3 MB     00:00    
2024-08-21T09:21:06.5645141Z CentOS Stream 9 - AppStream                      26 MB/s |  18 MB     00:00    
2024-08-21T09:21:31.2982402Z CentOS Stream 9 - CRB                           8.7 MB/s | 4.9 MB     00:00    
2024-08-21T09:21:38.5057946Z CentOS Stream 9 - Extras packages                24 kB/s |  18 kB     00:00    
2024-08-21T09:21:40.4918232Z Extra Packages for Enterprise Linux 9 - aarch64  20 MB/s |  22 MB     00:01    
2024-08-21T09:22:14.1977449Z Extra Packages for Enterprise Linux 9 openh264  3.0 kB/s | 2.5 kB     00:00    
2024-08-21T09:22:16.3262737Z Extra Packages for Enterprise Linux 9 - Next -  382 kB/s | 276 kB     00:00    
2024-08-21T09:22:19.6039533Z Last metadata expiration check: 0:00:01 ago on Wed 21 Aug 2024 09:22:16 AM UTC.
2024-08-21T09:22:30.4389033Z Dependencies resolved.
2024-08-21T09:22:30.4545142Z =======================================================================================
2024-08-21T09:22:30.4546269Z  Package                   Arch     Version                            Repo        Size
2024-08-21T09:22:30.4550150Z =======================================================================================
2024-08-21T09:22:30.4550814Z Installing:
2024-08-21T09:22:30.4553716Z  nginx                     aarch64  1:1.22.1-4.module_el9+666+132dc76f appstream   38 k
2024-08-21T09:22:30.4554975Z  postgresql                aarch64  13.14-1.el9                        appstream  1.6 M
2024-08-21T09:22:30.4556274Z  postgresql-contrib        aarch64  13.14-1.el9                        appstream  901 k
2024-08-21T09:22:30.4557765Z  postgresql-server         aarch64  13.14-1.el9                        appstream  5.6 M
2024-08-21T09:22:30.4559013Z  postgresql-upgrade        aarch64  13.14-1.el9                        appstream  4.5 M
2024-08-21T09:22:30.4560188Z  redis                     aarch64  6.2.7-1.el9                        appstream  1.3 M

@git-hyagi git-hyagi force-pushed the hardcode-postgres-version branch 4 times, most recently from b811ad0 to 1553350 Compare August 21, 2024 13:54
@decko
Copy link
Member

decko commented Aug 21, 2024

👏🏽 all green folks.

* Remove deprecated "update-ca-trust force-enable" call
* Create the `/var/run/postgresql` directory. In older versions
of postgresql-server package, this directory was created during
package installation. The newer versions are not creating it
anymore (because systemd was supposed to do it) which is breaking
our s6 based images.
* Change a Containerfile RUN instruction to run dnf once (not a fix,
just a little improvement)

[noissue]
@git-hyagi git-hyagi changed the title test Fix CI errors Aug 21, 2024
@git-hyagi git-hyagi marked this pull request as ready for review August 21, 2024 15:56
@lubosmj lubosmj merged commit 87209a9 into pulp:latest Aug 21, 2024
16 checks passed
@git-hyagi git-hyagi deleted the hardcode-postgres-version branch August 21, 2024 16:34
Copy link

patchback bot commented Aug 22, 2024

Backport to 3.49: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.49/87209a9e3a2f6437827f37cd9b712e1d475abdbb/pr-658

Backported as #660

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 22, 2024
git-hyagi pushed a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants