[Backport 3.49] Fix base image build having a selinux dependency collision #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Sep 18, 2024
| @@ -54,7 +54,7 @@ RUN dnf -y install python${PYTHON_VERSION} python3-cryptography python${PYTHON_V | |||
| dnf -y install libpq-devel && \ | |||
| dnf -y install python3-setuptools && \ | |||
| dnf -y install swig && \ | |||
| dnf -y install buildah --exclude container-selinux && \ | |||
| dnf -y install podman fuse-overlayfs buildah --exclude container-selinux && \ | |||
There was a problem hiding this comment.
Sounds good to me.
Is this selinux stuff a weak dependency? Should we think about https://discussion.fedoraproject.org/t/which-kind-of-dependencies-suggested-recommended-does-dnf-install/74111 in general?
mdellweg
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to check if the CI issue in #662 is due to the fact that the CI has been broken for 2 weeks and we don't have the latest images for it to pull from.