Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Opentelemetry instrumentation agent from the runtime #690

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

lubosmj
Copy link
Member

@lubosmj lubosmj commented Oct 30, 2024

We decided to instrument our application code manually by leveraging a customized middleware implemented in pulpcore.

Refer to pulp/pulpcore#5943 for more.

We decided to instrument our application code manually by leveraging a
customized middleware implemented in pulpcore.

Refer to pulp/pulpcore#5943 for more.
@lubosmj
Copy link
Member Author

lubosmj commented Oct 30, 2024

The agent instruments the application by discovering and applying the necessary instrumentation at runtime. In pulpcore, we needed to either install opentelemetry-instrumentation-aiohttp-server, opentelemetry-instrumentation-django or opentelemetry-instrumentation-wsgi in order to see the actual metrics being reported. By removing the agent and changing the infrastructure, we are also decoupling the dependencies scattered across the repositories.

@lubosmj lubosmj merged commit 97a31eb into pulp:latest Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants