Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an initContainer to register the gpg keys #1002

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

git-hyagi
Copy link
Collaborator

fixes: #1001

Thank you for your contribution!

If your PR needs a changelog entry:

If not, please add [noissue] to your commit message

- name: Set GPG initContainer image
set_fact:
gpg_init_container_image: >-
{{ lookup('env', 'GPG_INIT_CONTAINER_IMAGE') |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-name this to RELATED_IMAGE_GPG_INIT_CONTAINER ? The requirement is that the env var be prefixed with RELATED_IMAGE_.

@openshift-ci openshift-ci bot added the lgtm label Jul 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: git-hyagi, rooftopcellist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -11,6 +11,12 @@
status: "False"
lastTransitionTime: "{{ lookup('pipe', 'date --iso-8601=seconds') }}"

- name: Set GPG initContainer image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wanted to note that in the future, we should probably make this init container overridable by the user as a CRD param for community deployments with air-gapped deployments. But not a requirement for merge here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants