Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the old pulp-ci-centos:https image with updated service files #1386

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

lubosmj
Copy link
Member

@lubosmj lubosmj commented Sep 8, 2023

This is a temporary workaround that makes the CI green once again. The referenced image uses the pulp-ci-centos:https base image. On top of it, there are layers that contain updated service files which allows us to properly run pulpcore-api and pulpcore-content services.

We will revert the commit once we will be able to resolve the execution of nested containers.

ref pulp/pulpcore@4def68e#diff-15df6aebb457ef62acf7707d2032bf15dc24646d040d1bf2f892929263ce570dR16

ref pulp/pulp-oci-images#540

[noissue]

This is a temporary workaround that makes the CI green once again. The
referenced image uses the pulp-ci-centos:https base image. On top of it,
there are layers that contain updated service files which allows us to
properly run pulpcore-api and pulpcore-content services.

We will revert the commit once we will be able to resolve the execution
of nested containers.

ref pulp/pulpcore@4def68e#diff-15df6aebb457ef62acf7707d2032bf15dc24646d040d1bf2f892929263ce570dR16

ref pulp/pulp-oci-images#540

[noissue]
@lubosmj lubosmj force-pushed the fix-ci-failures-image-pulpcore-api branch from 3e6358b to 0ec8473 Compare September 8, 2023 15:31
@lubosmj lubosmj changed the title Use an image with updated service files Use the old pulp-ci-centos:https image with updated service files Sep 8, 2023
@lubosmj
Copy link
Member Author

lubosmj commented Sep 8, 2023

Containerfile of the updated image:

[lmjachky@localhost images]$ cat Containerfile.new.services 
FROM ghcr.io/pulp/pulp-ci-centos:https

COPY s6_assets/s6-rc.d/pulpcore-api /etc/s6-overlay/s6-rc.d/pulpcore-api
COPY s6_assets/s6-rc.d/pulpcore-content /etc/s6-overlay/s6-rc.d/pulpcore-content

COPY s6_assets/init/pulpcore-api /etc/init/pulpcore-api
COPY s6_assets/init/pulpcore-content /etc/init/pulpcore-content

@lubosmj lubosmj marked this pull request as ready for review September 8, 2023 15:45
@lubosmj lubosmj merged commit abdcf7c into pulp:main Sep 8, 2023
14 checks passed
@patchback
Copy link

patchback bot commented Sep 9, 2023

Backport to 2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.16/abdcf7c7c7d9422e2591d622cc65932227d22b8b/pr-1386

Backported as #1388

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Oct 31, 2023

Backport to 2.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.15/abdcf7c7c7d9422e2591d622cc65932227d22b8b/pr-1386

Backported as #1405

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants