Skip to content

Commit

Permalink
Remove actions.preTest in favor of integrationTestProvider (#1034)
Browse files Browse the repository at this point in the history
By using ci-mgmt's intended solution for running integration tests in
the `provider/` directory, we get a maintained test script and avoid
overloading the `actions.preTest` hook to run tests.

Related to pulumi/ci-mgmt#1276,
pulumi/ci-mgmt#1274 (comment)
  • Loading branch information
iwahbe authored Jan 10, 2025
1 parent d70992d commit b201511
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
7 changes: 1 addition & 6 deletions .ci-mgmt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ env:
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
team: ecosystem

actions:
preTest:
- name: Run provider tests
run: |
cd provider && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt
pulumiConvert: 1
registryDocs: true
integrationTestProvider: true
5 changes: 3 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,9 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
version: v2.5.0
- name: Run provider tests
run: |
cd provider && go test -v -json -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 . 2>&1 | tee /tmp/gotest.log | gotestfmt
if: matrix.testTarget == 'local'
working-directory: provider
run: go test -v -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -parallel 4 .
- name: Run tests
if: matrix.testTarget == 'local'
run: cd examples && go test -v -count=1 -cover -timeout 2h -tags=${{ matrix.language }} -skip TestPulumiExamples -parallel 4 .
Expand Down

0 comments on commit b201511

Please sign in to comment.