Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: override vra configuration cache #39

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Oct 12, 2023

This pr allows the following configurations to be overridable via env vars:

  • access_token (access token for API operations) with env var VMWARE_VRA_ACCESS_TOKEN
  • refresh_token (refresh token for API operations) with env var VMWARE_VRA_REFRESH_TOKEN
  • url (base url for API operations) with env var VMWARE_VRA_URL
  • reauthorizeTimeout (timeout for how often to reauthorize the access token) with env var VMWARE_VRA_REAUTHORIZE_TIMEOUT

@schmidtw schmidtw self-requested a review October 13, 2023 07:27
@schmidtw
Copy link
Collaborator

The changes look good. I'm not sure why the prerequisites failed due to an auth issue, but you need to regenerate the rest of the pulumi files like this:

make build_sdks

Then add them to the PR.

@denopink
Copy link
Contributor Author

@schmidtw sounds good, just regen the sdks

regarding the gh check failure, I think it's expecting to find a token in my fork repo but there's nothing there

@schmidtw schmidtw merged commit b78b5c8 into pulumiverse:main Oct 16, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants