-
-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #134 from punker76/jk/CentralPackageManagement
Use Central Package Management and update packages
- Loading branch information
Showing
11 changed files
with
140 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # PLEASE READ BEFORE POSTING AN ISSUE | ||
|
|
||
| This is a place for issues for MahApps.Metro.SimpleChildWindow itself. Questions are better asked at [discussions](https://github.com/punker76/MahApps.Metro.SimpleChildWindow/discussions). | ||
|
|
||
| ### Seriously consider creating and linking to a test repo which takes absolutely minimal setup to illustrate how reproduce the problem. | ||
|
|
||
| My time is limited and .Zip files, code snippets and partial examples are often a time sink. GitHub also provides great communication and code review tools which can be utilised. | ||
|
|
||
| ## HOW TO POST A GOOD SAMPLE. | ||
|
|
||
| Follow these guidelines and I will most likely look at the issue sooner: | ||
|
|
||
| * Post a full GitHub repository. Not a zip file, half baked snippet etc. If GitHub is new to you consider it a great learning opportunity and chance to get involved. | ||
| * The repository should have just ONE step max for me to get running, and that is "Restore NuGet Packages". If there are any other missing dependencies, or uncompiling features I will most likely move on to another issue. | ||
| * I'm not trying to be awkward. I'm just busy and I'm helping a lot of people, not just you, so help me out and I will help you out. | ||
|
|
||
| ## What steps will reproduce this issue? | ||
|
|
||
| _Write problem description here_ | ||
|
|
||
| ### Expected outcome | ||
|
|
||
| _Write expected outcome here_ | ||
|
|
||
| ### Repo | ||
|
|
||
| _Link to the Repo_ | ||
|
|
||
| ### Environment | ||
|
|
||
| - MahApps.Metro.SimpleChildWindow __v?.?.?__ | ||
| - MahApps.Metro __v?.?.?__ | ||
| - Windows OS __??__ | ||
| - Visual Studio __20xx__ | ||
| - .NET Framework __?.?__ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| ## What changed? | ||
|
|
||
| _Describe the changes you have made to improve this project._ | ||
|
|
||
| _Closed issues._ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,37 @@ | ||
| <Project> | ||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <PropertyGroup> | ||
| <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage> | ||
| <IsBuildingWpfTempProj Condition="$(MSBuildProjectName.Contains('_wpftmp')) != 'true'">false</IsBuildingWpfTempProj> | ||
| <IsBuildingWpfTempProj Condition="$(MSBuildProjectName.Contains('_wpftmp')) == 'true'">true</IsBuildingWpfTempProj> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- Project properties --> | ||
| <PropertyGroup> | ||
| <TargetFrameworks>net462;net47;net48;net5.0-windows;net6.0-windows</TargetFrameworks> | ||
| <AppendTargetFrameworkToOutputPath>true</AppendTargetFrameworkToOutputPath> | ||
| <GenerateDocumentationFile>false</GenerateDocumentationFile> | ||
| <AutoGenerateBindingRedirects Condition=" $(TargetFramework.StartsWith('net4')) ">true</AutoGenerateBindingRedirects> | ||
| <LangVersion>9</LangVersion> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <DebugType>full</DebugType> | ||
| <AutoGenerateBindingRedirects Condition="$(DefineConstants.Contains(NETCOREAPP)) == false">true</AutoGenerateBindingRedirects> | ||
| <LangVersion>latestmajor</LangVersion> | ||
| <NoWarn>$(NoWarn);CS1591</NoWarn> | ||
| <NoError>$(NoError);CS1591</NoError> | ||
| <UseWPF>true</UseWPF> | ||
| <!-- <TreatWarningsAsErrors>true</TreatWarningsAsErrors> --> | ||
| <!-- <Nullable>enable</Nullable> --> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- Add the references for all projects and targets --> | ||
| <ItemGroup> | ||
| <PackageReference Include="JetBrains.Annotations" PrivateAssets="All" IncludeAssets="build;compile" /> | ||
| <PackageReference Include="WpfAnalyzers" PrivateAssets="all" IncludeAssets="build;analyzers" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Remove="**\*.png;**\*.jpg;**\*.ico;**\*.ttf" /> | ||
| <Resource Include="**\*.png;**\*.jpg;**\*.ico;**\*.ttf" /> | ||
| <None Remove="**\*.png;**\*.jpg;**\*.ico;**\*.ttf;**\*.cur" /> | ||
| <Resource Include="**\*.png;**\*.jpg;**\*.ico;**\*.ttf;**\*.cur" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="JetBrains.Annotations" PrivateAssets="All" IncludeAssets="build;compile" /> | ||
| <PackageReference Include="WpfAnalyzers"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> | ||
| <SourceRoot Include="$(MSBuildThisFileDirectory)/" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | ||
| <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup Label="Build"> | ||
| <PackageVersion Include="MahApps.Metro" Version="[2.4.10, 3)" /> | ||
| <PackageVersion Include="JetBrains.Annotations" Version="2023.2.0" /> | ||
| <PackageVersion Include="MahApps.Metro.IconPacks" Version="4.11.0" /> | ||
| <PackageVersion Include="Costura.Fody" Version="5.7.0" /> | ||
|
|
||
| <PackageVersion Include="WpfAnalyzers" Version="4.1.1" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,24 @@ | ||
| <Project> | ||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
|
|
||
| <!-- SourceLink --> | ||
| <PropertyGroup> | ||
| <!-- Optional: Declare that the Repository URL can be published to NuSpec --> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| <!-- <IncludeSymbols>true</IncludeSymbols> --> | ||
| <!-- Optional: Embed source files that are not tracked by the source control manager to the PDB --> | ||
| <EmbedUntrackedSources>true</EmbedUntrackedSources> | ||
| <!-- Optional: Include PDB in the built .nupkg --> | ||
| <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder> | ||
| <!-- By using EmbedAllSources we don't need SourceLink itself --> | ||
| <!-- https://github.com/dotnet/sourcelink/blob/master/docs/README.md#embedallsources --> | ||
| <!-- <EmbedAllSources>true</EmbedAllSources>--> | ||
| <EmbedAllSources>true</EmbedAllSources> | ||
| </PropertyGroup> | ||
|
|
||
| <!-- PDB-Options --> | ||
| <PropertyGroup> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <DebugType>Embedded</DebugType> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <SourceRoot Include="$(MSBuildThisFileDirectory)/" /> | ||
| <SourceRoot Include="$(NuGetPackageRoot)" Condition="'$(NuGetPackageRoot)' != ''" /> | ||
| </ItemGroup> | ||
|
|
||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.Props', '$(MSBuildThisFileDirectory)../'))" /> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.build.props', '$(MSBuildThisFileDirectory)../'))" /> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 2 additions & 10 deletions
12
src/MahApps.Metro.SimpleChildWindow/MahApps.Metro.SimpleChildWindow.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,16 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
|
|
||
| <Project Sdk="Microsoft.NET.Sdk.WindowsDesktop"> | ||
| <!-- Project properties --> | ||
| <PropertyGroup> | ||
| <AssemblyName>MahApps.Metro.SimpleChildWindow</AssemblyName> | ||
| <Title>MahApps.Metro.SimpleChildWindow</Title> | ||
| <RootNamespace>MahApps.Metro.SimpleChildWindow</RootNamespace> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <OutputType>Library</OutputType> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="MahApps.Metro" /> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="MahApps.Metro" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Compile DependentUpon="%(Filename)" SubType="Code" Update="**\obj\**\*.g$(DefaultLanguageSourceExtension)" /> | ||
| <Compile DependentUpon="%(Filename)" SubType="Designer" Update="**\*.xaml$(DefaultLanguageSourceExtension)" /> | ||
| </ItemGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "6.0.100", | ||
| "rollForward": "latestFeature" | ||
| "version": "6.0.400", | ||
| "rollForward": "latestFeature", | ||
| "allowPrerelease": false | ||
| } | ||
| } |