Update checks

Recently, the checks action began failing because a newer version of
Bundler (2.5.0) removed support for Ruby 2.6 and 2.7. Because the checks
action runs on Ruby 2.7, the action started to fail.

This commit:
- Updates the Ruby version from 2.7 to 3.0.
- Unpins Rubocop from a three-year-old verison.
- Updates Rubocop's TargetRubyVersion from 2.4 to 2.7.
- Addresses minor style offenses found by the updated Rubocop.

.github/workflows/checks.yaml

@@ -13,8 +13,8 @@ jobs:
     strategy:
       matrix:
         cfg:
-          - {check: rubocop, os: ubuntu-latest, ruby: 2.7}
-          - {check: commits, os: ubuntu-latest, ruby: 2.7}
+          - {check: rubocop, os: ubuntu-latest, ruby: 3.0}
+          - {check: commits, os: ubuntu-latest, ruby: 3.0}
 
     runs-on: ${{ matrix.cfg.os }}
     steps:

.rubocop.yml

@@ -7,7 +7,7 @@ AllCops:
     - '.git/**/*'
     - 'bin/*'
     - 'output/**/*'
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.6
 
 Layout/LineLength:
   Enabled: false

Gemfile

@@ -16,7 +16,7 @@ gem 'json'
 gem 'octokit'
 gem 'packaging', *location_for(ENV['PACKAGING_LOCATION'] || '~> 0.105')
 gem 'rake'
-gem 'rubocop', '~> 1.5.2'
+gem 'rubocop', '~> 1.5'
 gem 'vanagon', *location_for(ENV['VANAGON_LOCATION'] || '~> 0.24')
 
 eval_gemfile("#{__FILE__}.local") if File.exist?("#{__FILE__}.local")

configs/components/puppet-runtime.rb

@@ -20,7 +20,7 @@
                       # so cmd.exe was not working as expected.
                       [
                         "gunzip -c #{tarball_name} | tar -k -C /cygdrive/c/ -xf -",
-                        "chmod 755 #{settings[:bindir].sub(/C:/, '/cygdrive/c')}/*"
+                        "chmod 755 #{settings[:bindir].sub('C:', '/cygdrive/c')}/*"
                       ]
                     elsif platform.is_macos?
                       # We can't untar into '/' because of SIP on macOS; Just copy the contents

configs/platforms/solaris-10-i386.rb

@@ -18,7 +18,7 @@
 # please see man -s 4 admin for details about this file:
 # http://www.opensolarisforum.org/man/man4/admin.html
 #
-# The key thing we don\'t want to prompt for are conflicting files.
+# The key thing we don't want to prompt for are conflicting files.
 # The other nocheck settings are mostly defensive to prevent prompts
 # We _do_ want to check for available free space and abort if there is
 # not enough
@@ -32,7 +32,7 @@
 # Do not bother checking package dependencies (We take care of this)
 idepend=nocheck
 rdepend=nocheck
-# DO check for available free space and abort if there isn\'t enough
+# DO check for available free space and abort if there isn't enough
 space=quit
 # Do not check for setuid files.
 setuid=nocheck

configs/platforms/solaris-10-sparc.rb

@@ -22,7 +22,7 @@
 # please see man -s 4 admin for details about this file:
 # http://www.opensolarisforum.org/man/man4/admin.html
 #
-# The key thing we don\'t want to prompt for are conflicting files.
+# The key thing we don't want to prompt for are conflicting files.
 # The other nocheck settings are mostly defensive to prevent prompts
 # We _do_ want to check for available free space and abort if there is
 # not enough
@@ -36,7 +36,7 @@
 # Do not bother checking package dependencies (We take care of this)
 idepend=nocheck
 rdepend=nocheck
-# DO check for available free space and abort if there isn\'t enough
+# DO check for available free space and abort if there isn't enough
 space=quit
 # Do not check for setuid files.
 setuid=nocheck

configs/platforms/solaris-11-sparc.rb

@@ -14,7 +14,7 @@
 # please see man -s 4 admin for details about this file:
 # http://www.opensolarisforum.org/man/man4/admin.html
 #
-# The key thing we don\'t want to prompt for are conflicting files.
+# The key thing we don't want to prompt for are conflicting files.
 # The other nocheck settings are mostly defensive to prevent prompts
 # We _do_ want to check for available free space and abort if there is
 # not enough
@@ -28,7 +28,7 @@
 # Do not bother checking package dependencies (We take care of this)
 idepend=nocheck
 rdepend=nocheck
-# DO check for available free space and abort if there isn\'t enough
+# DO check for available free space and abort if there isn't enough
 space=quit
 # Do not check for setuid files.
 setuid=nocheck