Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

Update checks action #107

Merged

Conversation

mhashizume
Copy link
Contributor

@mhashizume mhashizume commented Feb 8, 2024

Recently, the checks action began failing because a newer version of Bundler (2.5.0) removed support for Ruby 2.6 and 2.7. Because the checks action runs on Ruby 2.7, the action started to fail.

This commit:

  • Updates the Ruby version from 2.7 to 3.0.
  • Unpins Rubocop from a three-year-old verison.
  • Updates Rubocop's TargetRubyVersion from 2.4 to 2.6.
  • Addresses minor style offenses found by the updated Rubocop.
  • Removes the commit summary check, as Puppet no longer has a public Jira instance.

@mhashizume mhashizume force-pushed the maint/main/update-action branch 2 times, most recently from fd11e59 to 60acef7 Compare February 8, 2024 22:27
@mhashizume mhashizume changed the title Update Ruby for checks action Update checks action Feb 8, 2024
@mhashizume
Copy link
Contributor Author

I have enabled issues on this repo as part of this PR.

@mhashizume mhashizume marked this pull request as ready for review February 8, 2024 22:29
@mhashizume mhashizume requested a review from a team as a code owner February 8, 2024 22:29
Recently, the checks action began failing because a newer version of
Bundler (2.5.0) removed support for Ruby 2.6 and 2.7. Because the checks
action runs on Ruby 2.7, the action started to fail.

This commit:
- Updates the Ruby version from 2.7 to 3.0.
- Unpins Rubocop from a three-year-old verison.
- Updates Rubocop's TargetRubyVersion from 2.4 to 2.6.
- Addresses minor style offenses found by the updated Rubocop.
- Removes the commit summary check, as Puppet no longer has a public
  Jira instance.
@mhashizume mhashizume force-pushed the maint/main/update-action branch from 60acef7 to 16e2458 Compare February 8, 2024 22:37
@mhashizume mhashizume added the maintenance Maintenance chores are typically excluded from changelogs label Feb 8, 2024
@mhashizume mhashizume merged commit f6132c8 into puppetlabs-toy-chest:main Feb 8, 2024
2 checks passed
@mhashizume mhashizume added the backport 7.x Generate a backport PR to 7.x label Feb 8, 2024
@mhashizume mhashizume deleted the maint/main/update-action branch February 8, 2024 22:46
@mhashizume mhashizume removed the backport 7.x Generate a backport PR to 7.x label Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants