Add support for IPv6 #3604
Open
Add support for IPv6 #3604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traditional `netcat` has no support for IPv6. Support is implemented in `netcat-openbsd`, which should also be backward compatible. Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
jovandeginste
force-pushed
the
ipv6
branch
2 times, most recently
from
79ec355
to
41cc0c3
Compare
|
Can one of the admins verify this patch? |
The equivalent "all" interface to `0.0.0.0` for IPv6 is `::`; this _includes_ IPv4's `0.0.0.0`. In other words, this should be fully backward compatible. Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
|
Apologies for the force-pushes - I realized I also changed "old" (changelog) documentation, which is probably not to be touched. |
|
Hey @jovandeginste, thanks for this PR! The PuppetDB team is a bit overwhelmed with backlog at the moment, but we will discuss these changes as soon as we can. |
|
Any news on this? I'd love to have IPv6 working with the puppetdb container. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there are other missing parts, but so far it works for us with the changes in this PR.